maedhroz commented on code in PR #2420:
URL: https://github.com/apache/cassandra/pull/2420#discussion_r1242510685
##########
src/java/org/apache/cassandra/index/sai/disk/format/IndexComponent.java:
##########
@@ -79,10 +84,20 @@ public enum IndexComponent
*/
GROUP_COMPLETION_MARKER("GroupComplete");
+ public final Component.Type type;
public final String name;
IndexComponent(String name)
{
this.name = name;
+ this.type = componentType(name);
+ }
+
+ private static Component.Type componentType(String name)
+ {
+ return Component.Type.create(SAI_DESCRIPTOR + SAI_SEPARATOR +
name.toUpperCase(),
Review Comment:
nit: `toUpperCase()` here seems unnecessary, as it will give us weird things
like "GROUPCOMPLETE". Camel is ok?
I'm not even sure we can't just use `name`. The SSTable formats don't
namespace, although they don't have any conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
