pkolaczk commented on code in PR #2420:
URL: https://github.com/apache/cassandra/pull/2420#discussion_r1243330863
##########
src/java/org/apache/cassandra/io/sstable/Component.java:
##########
@@ -60,31 +61,34 @@ public final static class Type
/**
* Creates a new non-singleton type and registers it a global type
registry - see {@link #registerType(Type)}.
*
- * @param name type name, must be unique for this and all
parent formats
- * @param repr the regular expression to be used to recognize a
name represents this type
- * @param formatClass format class for which this type is defined for
+ * @param name type name, must be unique for this and all
parent formats
+ * @param repr the regular expression to be used to recognize
a name represents this type
+ * @param isStreamable whether components of this type should be
streamed to other nodes
+ * @param formatClass format class for which this type is defined for
*/
- public static Type create(String name, String repr, Class<? extends
SSTableFormat<?, ?>> formatClass)
+ public static Type create(String name, String repr, boolean
isStreamable, Class<? extends SSTableFormat<?, ?>> formatClass)
{
- return new Type(name, repr, false, formatClass);
+ return new Type(name, repr, false, isStreamable, formatClass);
Review Comment:
Fixed
##########
src/java/org/apache/cassandra/io/sstable/Component.java:
##########
@@ -60,31 +61,34 @@ public final static class Type
/**
* Creates a new non-singleton type and registers it a global type
registry - see {@link #registerType(Type)}.
*
- * @param name type name, must be unique for this and all
parent formats
- * @param repr the regular expression to be used to recognize a
name represents this type
- * @param formatClass format class for which this type is defined for
+ * @param name type name, must be unique for this and all
parent formats
+ * @param repr the regular expression to be used to recognize
a name represents this type
+ * @param isStreamable whether components of this type should be
streamed to other nodes
+ * @param formatClass format class for which this type is defined for
*/
- public static Type create(String name, String repr, Class<? extends
SSTableFormat<?, ?>> formatClass)
+ public static Type create(String name, String repr, boolean
isStreamable, Class<? extends SSTableFormat<?, ?>> formatClass)
{
- return new Type(name, repr, false, formatClass);
+ return new Type(name, repr, false, isStreamable, formatClass);
}
/**
* Creates a new singleton type and registers it in a global type
registry - see {@link #registerType(Type)}.
*
- * @param name type name, must be unique for this and all
parent formats
- * @param repr the regular expression to be used to recognize a
name represents this type
- * @param formatClass format class for which this type is defined for
+ * @param name type name, must be unique for this and all
parent formats
+ * @param repr the regular expression to be used to recognize
a name represents this type
+ * @param isStreamable whether components of this type should be
streamed to other nodes
+ * @param formatClass format class for which this type is defined for
*/
- public static Type createSingleton(String name, String repr, Class<?
extends SSTableFormat<?, ?>> formatClass)
+ public static Type createSingleton(String name, String repr, boolean
isStreamable, Class<? extends SSTableFormat<?, ?>> formatClass)
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
