Maxwell-Guo commented on code in PR #2433:
URL: https://github.com/apache/cassandra/pull/2433#discussion_r1244625542
##########
test/unit/org/apache/cassandra/index/sai/cql/CollectionIndexingTest.java:
##########
@@ -220,4 +222,9 @@ private void assertUnsupportedIndexOperator(int
expectedSize, String query, Obje
assertInvalidMessage(StatementRestrictions.REQUIRES_ALLOW_FILTERING_MESSAGE,
query, values);
assertEquals(expectedSize, execute(query + " ALLOW FILTERING").size());
}
+
+ private static String createIndexDDL(String target)
Review Comment:
1. `CREATE CUSTOM INDEX ON %s(VALUES(value)) USING 'StorageAttachedIndex'" `
2. `createIndexDDL(String target)`
1 is more intuitive than 2, as I know I am creating SAI when I see
StorageAttachedIndex, but I have no idea about what kind of index I am going to
create when see "createIndexDDL".
Of course, you don’t need to change it if you do not want to, because this
is just a very small point, which is insignificant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
