Maxwell-Guo commented on code in PR #2433:
URL: https://github.com/apache/cassandra/pull/2433#discussion_r1243065356
##########
test/unit/org/apache/cassandra/index/sai/cql/StorageAttachedIndexDDLTest.java:
##########
@@ -285,11 +335,10 @@ public void shouldCreateIndexOnReversedType() throws
Throwable
}
@Test
- public void shouldCreateIndexWithAlias()
+ public void shouldCreateIndexWithFullClassName()
{
createTable("CREATE TABLE %s (id text PRIMARY KEY, val text)");
-
- createIndex("CREATE CUSTOM INDEX ON %s(val) USING
'StorageAttachedIndex'");
+ createIndex("CREATE CUSTOM INDEX ON %s(val) USING
'org.apache.cassandra.index.sai.StorageAttachedIndex'");
Review Comment:
Yes, if we suggest users to use a certain method, at least a document
description or some warning is required. In my experience, if not, users either
cannot use it or use it blindly.
In the end, this experience was terrible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
