jbellis commented on code in PR #2451:
URL: https://github.com/apache/cassandra/pull/2451#discussion_r1245496417
##########
src/java/org/apache/cassandra/index/sai/disk/io/IndexInputReader.java:
##########
@@ -72,36 +75,6 @@ public void readBytes(byte[] bytes, int off, int len) throws
IOException
input.readFully(bytes, off, len);
}
- /**
- * Using {@link RandomAccessReader#readShort()} directly is faster than
{@link DataInput#readShort()} which calls
- * {@link DataInput#readByte()} one by one
- */
- @Override
- public short readShort() throws IOException
- {
- return input.readShort();
- }
-
- /**
- * Using {@link RandomAccessReader#readInt()} directly is faster than
{@link DataInput#readInt()} which
- * calls {@link DataInput#readByte()} one by one
- */
- @Override
- public int readInt() throws IOException
- {
- return input.readInt();
- }
-
- /**
- * Using {@link RandomAccessReader#readLong()} directly is faster than
{@link DataInput#readLong()} which
- * calls {@link DataInput#readByte()} one by one
- */
- @Override
- public long readLong() throws IOException
- {
- return input.readLong();
- }
-
Review Comment:
those are necessary because of the comment that you wanted to turn into a
javadoc
simpler and probably more performant to remove them and let the parent class
do its thing, than to override and add in a reverseBytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
