jbellis commented on code in PR #2451:
URL: https://github.com/apache/cassandra/pull/2451#discussion_r1245497715
##########
src/java/org/apache/cassandra/index/sai/disk/io/IndexInputReader.java:
##########
@@ -33,6 +33,9 @@
*/
public class IndexInputReader extends IndexInput
{
+ // the byte order of `input`'s native readX operations doesn't matter,
+ // because we only use `readFully` and `readByte` methods. IndexInput
calls these
+ // (via DataInput) with methods that enforce LittleEndian-ness.
Review Comment:
I could go either way on this, in general I prefer to keep implementation
details as a comment instead of javadoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
