smiklosovic commented on code in PR #2320:
URL: https://github.com/apache/cassandra/pull/2320#discussion_r1247113139
##########
build.xml:
##########
@@ -1808,11 +1816,21 @@
<option name="ADDITIONAL_OPTIONS_STRING" value="--add-exports
java.rmi/sun.rmi.registry=ALL-UNNAMED" />
</component>
</project>]]></echo>
- <echo>"IDE configuration updated for use with JDK11"</echo>
+ <echo>"IDE configuration updated for use with
JDK${ant.java.version}"</echo>
+ <echo>Please note that `ant realclean` does *NOT* remove
IntelliJ-specific files</echo>
+ <echo/>
+ <echo>Warning! If you observer strange behavior in IntelliJ please</echo>
+ <echo>verify that the SDK that is being used is indeed version
${ant.java.version}.</echo>
+ <echo>The used JDK version can be verified in Project Structure/Project
Setting/Project</echo>
+ <echo>and Project Structure/Platform Setting/SDKs</echo>
+ <echo>In particular it is worth checking if the used JDK, typically
named "${ant.java.version}",</echo>
+ <echo>indeed points to a java ${ant.java.version} installation.</echo>
</target>
<!-- Generate IDEA project description files -->
<target name="generate-idea-files"
depends="init,resolver-dist-lib,gen-cql3-grammar,generate-jflex-java,createVersionPropFile"
description="Generate IDEA files">
+ <delete dir=".idea"/>
Review Comment:
@michaelsembwever technically, we still do not have a way how to clean idea
files. realclean is not removing what generate-idea-files generated. (at least
not in this branch, right?)
That being said, why would one ever need such target anyway? It is not like
we are switching from Netbeans to IDEA and back frequently so we need to have
_a dedicated target for that_. At least there is less clutter. People just call
that target once and that's it. I do not see any use case for having a separate
target to clean it. People can just remove the files if they switch to Netbeans
or whatever else once in 5 years.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]