jakubzytka commented on code in PR #2320:
URL: https://github.com/apache/cassandra/pull/2320#discussion_r1247866706
##########
build.xml:
##########
@@ -1808,11 +1816,21 @@
<option name="ADDITIONAL_OPTIONS_STRING" value="--add-exports
java.rmi/sun.rmi.registry=ALL-UNNAMED" />
</component>
</project>]]></echo>
- <echo>"IDE configuration updated for use with JDK11"</echo>
+ <echo>"IDE configuration updated for use with
JDK${ant.java.version}"</echo>
+ <echo>Please note that `ant realclean` does *NOT* remove
IntelliJ-specific files</echo>
+ <echo/>
+ <echo>Warning! If you observer strange behavior in IntelliJ please</echo>
+ <echo>verify that the SDK that is being used is indeed version
${ant.java.version}.</echo>
+ <echo>The used JDK version can be verified in Project Structure/Project
Setting/Project</echo>
+ <echo>and Project Structure/Platform Setting/SDKs</echo>
+ <echo>In particular it is worth checking if the used JDK, typically
named "${ant.java.version}",</echo>
+ <echo>indeed points to a java ${ant.java.version} installation.</echo>
</target>
<!-- Generate IDEA project description files -->
<target name="generate-idea-files"
depends="init,resolver-dist-lib,gen-cql3-grammar,generate-jflex-java,createVersionPropFile"
description="Generate IDEA files">
+ <delete dir=".idea"/>
Review Comment:
> People just call that target once and that's it.
This assumes that you work with only one JDK in one repo.
I admit this is how *I* do work, but I know that others do not - and that
they switch the JDK version. Thus they need to re-generate idea files.
##########
build.xml:
##########
@@ -1808,11 +1816,21 @@
<option name="ADDITIONAL_OPTIONS_STRING" value="--add-exports
java.rmi/sun.rmi.registry=ALL-UNNAMED" />
</component>
</project>]]></echo>
- <echo>"IDE configuration updated for use with JDK11"</echo>
+ <echo>"IDE configuration updated for use with
JDK${ant.java.version}"</echo>
+ <echo>Please note that `ant realclean` does *NOT* remove
IntelliJ-specific files</echo>
+ <echo/>
+ <echo>Warning! If you observer strange behavior in IntelliJ please</echo>
+ <echo>verify that the SDK that is being used is indeed version
${ant.java.version}.</echo>
+ <echo>The used JDK version can be verified in Project Structure/Project
Setting/Project</echo>
+ <echo>and Project Structure/Platform Setting/SDKs</echo>
+ <echo>In particular it is worth checking if the used JDK, typically
named "${ant.java.version}",</echo>
+ <echo>indeed points to a java ${ant.java.version} installation.</echo>
</target>
<!-- Generate IDEA project description files -->
<target name="generate-idea-files"
depends="init,resolver-dist-lib,gen-cql3-grammar,generate-jflex-java,createVersionPropFile"
description="Generate IDEA files">
+ <delete dir=".idea"/>
Review Comment:
> People just call that target once and that's it.
This assumes that you work with only one JDK in one repo.
I admit this is how *I* do work, but I know that others do not - and that
they switch the JDK version. Thus they need to re-generate idea files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
