pkolaczk commented on PR #2460: URL: https://github.com/apache/cassandra/pull/2460#issuecomment-1623015738
> After that, shouldTakeAndRestoreSnapshots() in SnapshotTest will still fail, and that's because the test was always incorrect. Changing line 107 to assertValidationCount(4, 2); should properly verify that full rebuild checksums the SSTable-level index components. I'm not convinced the test is broken. The comment says that the index shouldn't validate after rebuild / compaction and that makes IMHO sense. Why validate an index we just wrote? @mike-tr-adamson ^ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
