maedhroz commented on code in PR #2460:
URL: https://github.com/apache/cassandra/pull/2460#discussion_r1256489976
##########
src/java/org/apache/cassandra/index/sai/StorageAttachedIndexBuilder.java:
##########
@@ -261,8 +261,9 @@ private CountDownLatch
shouldWritePerSSTableFiles(SSTableReader sstable)
{
// if per-table files are incomplete or checksum failed during full
rebuild.
IndexDescriptor indexDescriptor = IndexDescriptor.create(sstable);
- if (!indexDescriptor.isPerSSTableIndexBuildComplete() ||
- (isFullRebuild &&
!indexDescriptor.validatePerSSTableComponentsChecksum()))
+ if (!indexDescriptor.isPerSSTableIndexBuildComplete()
+ || isFullRebuild
Review Comment:
When we initially wrote this, we couldn't think of any cases where the
SSTable-level indexes would need to be rebuilt if existing and valid. The
column-level bits are typically what need to change, say if you slightly
changed filtering/analysis on a text field. However, I'm not opposed to this if
you think it's clearer that "full rebuild" really means "full" rebuild :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
