smiklosovic commented on code in PR #2458: URL: https://github.com/apache/cassandra/pull/2458#discussion_r1259411595
########## src/java/org/apache/cassandra/locator/AbstractCloudMetadataServiceSnitch.java: ########## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.locator; + +import java.util.Map; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import org.apache.cassandra.db.SystemKeyspace; +import org.apache.cassandra.gms.ApplicationState; +import org.apache.cassandra.gms.EndpointState; +import org.apache.cassandra.gms.Gossiper; +import org.apache.cassandra.utils.FBUtilities; +import org.apache.cassandra.utils.Pair; + +import static java.lang.String.format; + +abstract class AbstractCloudMetadataServiceSnitch extends AbstractNetworkTopologySnitch +{ + static final Logger logger = LoggerFactory.getLogger(AbstractCloudMetadataServiceSnitch.class); + + static final String DEFAULT_DC = "UNKNOWN-DC"; + static final String DEFAULT_RACK = "UNKNOWN-RACK"; + + protected final AbstractCloudMetadataServiceConnector connector; + protected final SnitchProperties snitchProperties; + + private final String localRack; + private final String localDc; + + private Map<InetAddressAndPort, Map<String, String>> savedEndpoints; + + public AbstractCloudMetadataServiceSnitch(AbstractCloudMetadataServiceConnector connector, + SnitchProperties snitchProperties, + Pair<String, String> dcAndRack) + { + this.connector = connector; + this.snitchProperties = snitchProperties; + this.localDc = dcAndRack.left; + this.localRack = dcAndRack.right; + + logger.info(format("%s using datacenter: %s, rack: %s, connector: %s, properties: %s", + getClass().getName(), getLocalDc(), getLocalRack(), connector, snitchProperties)); + } + + @Override + public String getLocalRack() + { + return localRack; + } + + public String getLocalDc() Review Comment: great catch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
