smiklosovic commented on code in PR #2458:
URL: https://github.com/apache/cassandra/pull/2458#discussion_r1259542990
##########
src/java/org/apache/cassandra/locator/AbstractCloudMetadataServiceConnector.java:
##########
@@ -61,6 +80,7 @@ public String apiCall(String url,
conn = (HttpURLConnection) new URL(url + query).openConnection();
extraHeaders.forEach(conn::setRequestProperty);
conn.setRequestMethod(method);
+ conn.setConnectTimeout(30000);
Review Comment:
Anyway, I think I will do it in such a way that we will pass
SnitchProperties to connector. Because my gut feeling tells me that there might
be connectors which might be somehow further configured. Now it is pretty
simple, just metadata url and possibly timeout, but what if connectors need
something fancy? I dont know ... certificates? You feel me. So the needs to be
a way how to get the access to all snitch properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
