adelapena commented on code in PR #2467:
URL: https://github.com/apache/cassandra/pull/2467#discussion_r1261057703
##########
src/java/org/apache/cassandra/service/StorageServiceMBean.java:
##########
@@ -1124,16 +1124,6 @@ public void enableAuditLog(String loggerName, String
includedKeyspaces, String e
public boolean autoOptimisePreviewRepairStreams();
public void setAutoOptimisePreviewRepairStreams(boolean enabled);
- // warning thresholds will be replaced by equivalent guardrails
Review Comment:
I also think they should be left `@Deprecated`, since they are only for
backward compatibility. If we directly translate the arguments of those methods
to the guardrail thresholds we are changing their meaning, since they used to
count system keyspace/tables.
I think the setter methods on `StorageService` should subtract the number of
system keyspaces/tables. Conversely, the getters should add the number of
system keyspaces/tables to the guardrail number. That way the MBean methods
would behave the same way they used to, being a JMX version of the old config
properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
