djatnieks commented on code in PR #2467:
URL: https://github.com/apache/cassandra/pull/2467#discussion_r1261611429
##########
src/java/org/apache/cassandra/service/StorageServiceMBean.java:
##########
@@ -1124,16 +1124,6 @@ public void enableAuditLog(String loggerName, String
includedKeyspaces, String e
public boolean autoOptimisePreviewRepairStreams();
public void setAutoOptimisePreviewRepairStreams(boolean enabled);
- // warning thresholds will be replaced by equivalent guardrails
Review Comment:
Hmm, yes, I think you are right about that. I was thinking that legacy
values from the config would have been converted already, and users would want
to work with current guardrail values. But, as you point out, that changes the
semantics of the api, and since we are leaving the api methods deprecated they
should work the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
