dcapwell commented on PR #50:
URL: https://github.com/apache/cassandra-accord/pull/50#issuecomment-1636311430

   Talking to @belliottsmith in slack, but seems that the current logic has 
issues with adding/removing keyspaces, so publishing errors to him in slack 
rather than here as this PR is already dense so hard to track.
   
   One thing I see is that the logic on trunk I added to have topologies not 
fail when you ask for a keyspace that isn't known was removed (intuitionally) 
and that causes things to fail
   
   ```
   12:13:28.706 [Test worker] ERROR accord.impl.InMemoryCommandStore - Uncaught 
exception
   java.lang.IllegalArgumentException: Range not found for (4#60853,4#61438]
        at accord.topology.Topology.subsetFor(Topology.java:259)
        at accord.topology.Topology.forSelection(Topology.java:206)
        at 
accord.topology.TopologyManager.withSufficientEpochs(TopologyManager.java:506)
        at 
accord.topology.TopologyManager.withOpenEpochs(TopologyManager.java:466)
        at 
accord.coordinate.CoordinateSyncPoint.<init>(CoordinateSyncPoint.java:56)
        at 
accord.coordinate.CoordinateSyncPoint.coordinate(CoordinateSyncPoint.java:85)
        at accord.local.Bootstrap$Attempt.start(Bootstrap.java:136)
        at accord.local.Bootstrap.restart(Bootstrap.java:454)
        at accord.local.Bootstrap.start(Bootstrap.java:440)
   ```
   
   here we are asking epoch=1 for a range found in epoch=3 (epoch=2 adds the 
new keyspace, and epoch=3 is a split moving ranges around)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to