dcapwell commented on code in PR #50:
URL: https://github.com/apache/cassandra-accord/pull/50#discussion_r1265970396
##########
accord-core/src/main/java/accord/local/CommandStore.java:
##########
@@ -47,34 +46,72 @@
import java.util.Set;
import java.util.TreeMap;
import java.util.concurrent.Callable;
+import java.util.concurrent.atomic.AtomicReference;
import java.util.function.Consumer;
import java.util.function.Function;
import java.util.function.Supplier;
-import accord.primitives.Seekables;
-import accord.primitives.TxnId;
import accord.utils.async.AsyncResults;
import com.google.common.collect.ImmutableSortedMap;
import static accord.api.ConfigurationService.EpochReady.DONE;
+import static accord.local.CommandStore.EpochUpdateHolder.*;
import static accord.local.PreLoadContext.contextFor;
import static accord.local.PreLoadContext.empty;
+import static accord.primitives.AbstractRanges.UnionMode.MERGE_ADJACENT;
+import static accord.primitives.Routables.Slice.Minimal;
import static accord.primitives.Txn.Kind.ExclusiveSyncPoint;
/**
* Single threaded internal shard of accord transaction metadata
*/
public abstract class CommandStore implements AgentExecutor
{
+ public static class EpochUpdateHolder extends AtomicReference<EpochUpdate>
Review Comment:
```
$ ./gradlew clean build
Picked up _JAVA_OPTIONS: -Djava.net.preferIPv4Stack=true
-Dchronicle.analytics.disable=true
> Task :accord-core:compileJava FAILED
/Users/dcapwell/src/github/apache/cassandra-accord/prs/trunk/accord-core/src/main/java/accord/local/CommandStore.java:71:
error: cannot find symbol
public static class EpochUpdateHolder extends
AtomicReference<EpochUpdate>
^
symbol: class EpochUpdate
location: class accord.local.CommandStore
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 error
FAILURE: Build failed with an exception.
```
```suggestion
public static class EpochUpdateHolder extends
AtomicReference<EpochUpdateHolder.EpochUpdate>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
