maedhroz commented on code in PR #2492:
URL: https://github.com/apache/cassandra/pull/2492#discussion_r1265064034
##########
src/java/org/apache/cassandra/index/SecondaryIndexManager.java:
##########
@@ -491,9 +497,83 @@ public static String getIndexName(String cfName)
return StringUtils.substringAfter(cfName,
Directories.SECONDARY_INDEX_NAME_SEPARATOR);
}
+ // TODO: JavaDoc if this approach survives...mention that this should not
be used for live SSTables
+ public void validateStorageAttachedIndexes(Collection<SSTableReader>
sstables) throws IOException
Review Comment:
Right now, this method exists solely to validate SAI components streamed
entirely before we allow a streaming transaction to commit. It therefore
replaces any such validation that would occur via notification in
`StorageAttachedIndexGroup` (which should only worry about adding the new
SSTable indexes to the view, etc.).
This might also be useful for import, however, in the case where we bring in
new SSTables that already have built index components. We'd just have to make
sure we only did it in this case and not when we need to build them anyway...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
