maedhroz commented on code in PR #2492:
URL: https://github.com/apache/cassandra/pull/2492#discussion_r1265071251
##########
src/java/org/apache/cassandra/index/SecondaryIndexManager.java:
##########
@@ -491,9 +497,83 @@ public static String getIndexName(String cfName)
return StringUtils.substringAfter(cfName,
Directories.SECONDARY_INDEX_NAME_SEPARATOR);
}
+ // TODO: JavaDoc if this approach survives...mention that this should not
be used for live SSTables
+ public void validateStorageAttachedIndexes(Collection<SSTableReader>
sstables) throws IOException
Review Comment:
I think it would be possible to just add an argument indicating a failure
mode to this method. Streaming could fail hard if missing anything in the
entire SSTable case, and import could just validate what's there, given the
rest will be built anyway immediately after.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
