smiklosovic commented on code in PR #2505:
URL: https://github.com/apache/cassandra/pull/2505#discussion_r1270668249
##########
.build/build-resolver.xml:
##########
@@ -246,6 +247,14 @@
<file
file="${local.repository}/org/apache/cassandra/deps/sigar-bin/libsigar-x86-linux.so"/>
<file
file="${local.repository}/org/apache/cassandra/deps/sigar-bin/libsigar-x86-solaris.so"/>
</copy>
+
+ <copy todir="${build.lib}/corretto" quiet="true">
+ <file
file="${local.repository}/software/amazon/cryptools/AmazonCorrettoCryptoProvider/2.2.0/AmazonCorrettoCryptoProvider-2.2.0-linux-x86_64.jar"/>
+ <file
file="${local.repository}/software/amazon/cryptools/AmazonCorrettoCryptoProvider/2.2.0/AmazonCorrettoCryptoProvider-2.2.0-linux-aarch_64.jar"/>
+ </copy>
+
+ <delete
file="${build.lib}/AmazonCorrettoCryptoProvider-2.2.0-linux-x86_64.jar"
failonerror="false"/>
+ <delete
file="${build.lib}/AmazonCorrettoCryptoProvider-2.2.0-linux-aarch_64.jar"
failonerror="false"/>
Review Comment:
because when doing `ant jar`, since that dependency is in pom.xml, resolver
will copy all libraries as dependencies to `libs`. But we are also copying x86
and aarch to `corretto` dir. So you would have there these files two times.
##########
.build/build-resolver.xml:
##########
@@ -279,6 +288,15 @@
<url
url="${lib.download.base.url}/lib/sigar-bin/libsigar-x86-linux.so"/>
<url
url="${lib.download.base.url}/lib/sigar-bin/libsigar-x86-solaris.so"/>
</get>
+
+
+ <!-- Amazon Corretto Crypto Providers for various architectures -->
+ <get
src="${artifact.github.release}/corretto/amazon-corretto-crypto-provider/releases/download/2.2.0/AmazonCorrettoCryptoProvider-2.2.0-linux-x86_64.jar"
+
dest="${local.repository}/software/amazon/cryptools/AmazonCorrettoCryptoProvider/2.2.0/AmazonCorrettoCryptoProvider-2.2.0-linux-x86_64.jar"
+ usetimestamp="true" quiet="true" skipexisting="true"/>
+ <get
src="${artifact.github.release}/corretto/amazon-corretto-crypto-provider/releases/download/2.2.0/AmazonCorrettoCryptoProvider-2.2.0-linux-aarch_64.jar"
+
dest="${local.repository}/software/amazon/cryptools/AmazonCorrettoCryptoProvider/2.2.0/AmazonCorrettoCryptoProvider-2.2.0-linux-aarch_64.jar"
+ usetimestamp="true" quiet="true" skipexisting="true"/>
Review Comment:
probably possible, yeah...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
