smiklosovic commented on code in PR #2505:
URL: https://github.com/apache/cassandra/pull/2505#discussion_r1270662625
##########
src/java/org/apache/cassandra/security/DefaultCryptoProvider.java:
##########
@@ -39,11 +39,20 @@ public void installProvider()
{
try
{
- AmazonCorrettoCryptoProvider.install();
+
Class.forName("com.amazon.corretto.crypto.provider.AmazonCorrettoCryptoProvider");
Review Comment:
@michaelsembwever then you would have a completely different implementation
of `ICryptoProvider` which you reference in `crypto_provider`.
I was thinking about abstracting this logic so the same pattern would be
used, "Amazon provider" would just override few values, the class to load, how
installation and check is going to look like, but otherwise it would be all
same for all specific crypto providers.
It looks like
crypto_provider:
- class_name: abc
parameters:
- a: b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
