michaelsembwever commented on code in PR #2505:
URL: https://github.com/apache/cassandra/pull/2505#discussion_r1272656103
##########
.build/parent-pom-template.xml:
##########
@@ -233,12 +233,52 @@
<id>zznate</id>
<name>Nate McCall</name>
</developer>
+ <developer>
+ <id>smiklosovic</id>
+ <name>Stefan Miklosovic</name>
+ </developer>
</developers>
<scm>
<connection>scm:https://gitbox.apache.org/repos/asf/cassandra.git</connection>
<developerConnection>scm:https://gitbox.apache.org/repos/asf/cassandra.git</developerConnection>
<url>https://gitbox.apache.org/repos/asf?p=cassandra.git;a=tree</url>
</scm>
+
+ <profiles>
+ <profile>
+ <id>x86_64</id>
+ <activation>
+ <os>
+ <arch>!aarch64</arch>
Review Comment:
for now we need something as a default even if it doesn't successfully load
the .so files.
that's why it's `! aarch64` (as confusing as that might first read.)
let's add a comment explaining the contortion…
##########
.build/parent-pom-template.xml:
##########
@@ -233,12 +233,52 @@
<id>zznate</id>
<name>Nate McCall</name>
</developer>
+ <developer>
+ <id>smiklosovic</id>
+ <name>Stefan Miklosovic</name>
+ </developer>
</developers>
<scm>
<connection>scm:https://gitbox.apache.org/repos/asf/cassandra.git</connection>
<developerConnection>scm:https://gitbox.apache.org/repos/asf/cassandra.git</developerConnection>
<url>https://gitbox.apache.org/repos/asf?p=cassandra.git;a=tree</url>
</scm>
+
+ <profiles>
+ <profile>
+ <id>x86_64</id>
+ <activation>
+ <os>
+ <arch>!aarch64</arch>
Review Comment:
for now we need something as a default even if it doesn't successfully load
the .so files.
that's why it's `! aarch64` (as confusing as that might first read.)
let's add a comment explaining the contortion…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
