Mmuzaf commented on code in PR #2505:
URL: https://github.com/apache/cassandra/pull/2505#discussion_r1272633934
##########
.build/parent-pom-template.xml:
##########
@@ -233,12 +233,52 @@
<id>zznate</id>
<name>Nate McCall</name>
</developer>
+ <developer>
+ <id>smiklosovic</id>
+ <name>Stefan Miklosovic</name>
+ </developer>
</developers>
<scm>
<connection>scm:https://gitbox.apache.org/repos/asf/cassandra.git</connection>
<developerConnection>scm:https://gitbox.apache.org/repos/asf/cassandra.git</developerConnection>
<url>https://gitbox.apache.org/repos/asf?p=cassandra.git;a=tree</url>
</scm>
+
+ <profiles>
+ <profile>
+ <id>x86_64</id>
+ <activation>
+ <os>
+ <arch>!aarch64</arch>
Review Comment:
My concern is about putting something in the classpath that doesn't match
the architecture type, so even if the cassandra is able to handle this case
it's good, but the other applications may not.
If you think this will work, let's resolve this comment, I just wanted to
point out a potential problem, but in fact, it may not even exist :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]