michaelsembwever commented on code in PR #2506:
URL: https://github.com/apache/cassandra/pull/2506#discussion_r1273533610
##########
src/java/org/apache/cassandra/db/filter/ColumnFilter.java:
##########
@@ -182,67 +180,6 @@ boolean areAllFetchedColumnsQueried()
abstract RegularAndStaticColumns getFetchedColumns(TableMetadata
metadata, RegularAndStaticColumns queried);
}
- /**
- * Returns {@code true} if there are pre-4.0-rc2 nodes in the cluster,
{@code false} otherwise.
- *
- * <p>ColumnFilters from 4.0 releases before RC2 wrongly assumed that
fetching all regular columns and not
- * the static columns was enough. That was not the case for queries that
needed to return rows for empty partitions.
- * See CASSANDRA-16686 for more details.</p>
- */
- private static boolean isUpgradingFromVersionLowerThan40RC2()
- {
- if
(Gossiper.instance.isUpgradingFromVersionLowerThan(CassandraVersion.CASSANDRA_4_0_RC2))
- {
- logger.trace("ColumnFilter conversion has been applied so that
static columns will not be fetched because there are pre 4.0-rc2 nodes in the
cluster");
Review Comment:
done
##########
src/java/org/apache/cassandra/db/filter/ColumnFilter.java:
##########
@@ -182,67 +180,6 @@ boolean areAllFetchedColumnsQueried()
abstract RegularAndStaticColumns getFetchedColumns(TableMetadata
metadata, RegularAndStaticColumns queried);
}
- /**
- * Returns {@code true} if there are pre-4.0-rc2 nodes in the cluster,
{@code false} otherwise.
- *
- * <p>ColumnFilters from 4.0 releases before RC2 wrongly assumed that
fetching all regular columns and not
- * the static columns was enough. That was not the case for queries that
needed to return rows for empty partitions.
- * See CASSANDRA-16686 for more details.</p>
- */
- private static boolean isUpgradingFromVersionLowerThan40RC2()
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
