adelapena commented on code in PR #2506:
URL: https://github.com/apache/cassandra/pull/2506#discussion_r1273599243
##########
test/unit/org/apache/cassandra/db/filter/ColumnFilterTest.java:
##########
@@ -86,7 +86,7 @@ public class ColumnFilterTest
@Parameterized.Parameters(name = "{index}: clusterMinVersion={0}")
public static Collection<Object[]> data()
{
- return Arrays.asList(new Object[]{ "3.0" }, new Object[]{ "3.11" },
new Object[]{ "4.0-rc1" }, new Object[]{ "4.0" });
+ return (Collection) Arrays.asList(new Object[]{ "4.0" });
Review Comment:
Future messaging versions won't necessarily affect `ColumnFilter`. For
example, `VERSION_50` doesn't change anything about column filters. In any
case, I think we should remove the four `"4.0".equals(clusterMinVersion)`
checks since they are no-op.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
