yifan-c commented on code in PR #63:
URL: https://github.com/apache/cassandra-sidecar/pull/63#discussion_r1273910396
##########
vertx-client/build.gradle:
##########
@@ -56,7 +56,11 @@ dependencies {
api(group: 'io.vertx', name: 'vertx-web-client', version: '4.4.1') {
exclude group: 'com.fasterxml.jackson.core', module: 'jackson-core'
}
- implementation(group: 'io.netty', name: 'netty-tcnative-boringssl-static',
version: '2.0.44.Final') // for openSSL
+ implementation(group: 'io.netty', name: 'netty-tcnative-boringssl-static',
version: '2.0.61.Final') // for openSSL
+ implementation(group: 'io.netty', name: 'netty-tcnative-boringssl-static',
version: '2.0.61.Final', classifier: 'linux-x86_64') // for openSSL
+ implementation(group: 'io.netty', name: 'netty-tcnative-boringssl-static',
version: '2.0.61.Final', classifier: 'osx-aarch_64') // for openSSL
+ implementation(group: 'io.netty', name: 'netty-tcnative-boringssl-static',
version: '2.0.61.Final', classifier: 'linux-aarch_64') // for openSSL
+ implementation(group: 'io.netty', name: 'netty-tcnative-boringssl-static',
version: '2.0.61.Final', classifier: 'osx-x86_64') // for openSSL
Review Comment:
Hmm... I think the dependency at line#59 already includes all variants. It
either downloads all variants or download with a classifier.
##########
scripts/get-hostname.sh:
##########
@@ -0,0 +1,30 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+if [[ $# -eq 0 ]] ; then
+ echo 'A URI must be provided'
+ exit 1
+fi
+
+hostname=$(echo "${1}" | sed -E 's/^\s*.*:\/\///g')
+hostname=${hostname%%/*}
+hostname=${hostname%%:*}
+hostname=$(echo "${hostname}" | cut -d@ -f2-)
Review Comment:
It would be helpful to add a comment on what those lines do.
##########
scripts/build-dtest-jars.sh:
##########
@@ -27,7 +27,8 @@ mkdir -p "${BUILD_DIR}"
# host key verification
mkdir -p ~/.ssh
-ssh-keyscan github.com >> ~/.ssh/known_hosts
+REPO_HOST=$("${SCRIPT_DIR}/get-hostname.sh" "${REPO}")
Review Comment:
nit: instead of eval the script, it could source the script if the
functionality is defined as a function.
##########
vertx-client-shaded/build.gradle:
##########
@@ -55,8 +72,7 @@ shadowJar {
relocate 'com.fasterxml.jackson.databind',
'o.a.c.sidecar.client.shaded.com.fasterxml.jackson.databind'
relocate 'io.netty', 'o.a.c.sidecar.client.shaded.io.netty'
relocate 'io.vertx', 'o.a.c.sidecar.client.shaded.io.vertx'
- relocate 'META-INF/native/libnetty',
'META-INF/native/sidecar_client_netty_shaded_netty'
- relocate 'META-INF/native/netty',
'META-INF/native/io_sidecar_client_netty_shaded_netty'
+ relocate 'META-INF/native/libnetty',
'META-INF/native/libo_a_c_sidecar_client_shaded_netty'
relocate 'META-INF/versions/11/io/vertx',
'META-INF/versions/11/o/a/c/sidecar/client/shaded/io/vertx'
Review Comment:
line#75 is using `_` to delimit, but line#76 is using `/` for `o/a/c`. Can
you update them to use the same pattern?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
