yifan-c commented on code in PR #63: URL: https://github.com/apache/cassandra-sidecar/pull/63#discussion_r1273952828
########## scripts/functions.sh: ########## @@ -0,0 +1,42 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +get_hostname() { + if [[ $# -eq 0 ]] ; then + echo 'An URI must be provided' + exit 1 + fi + + # removes the scheme portion of the URI (i.e. https://, http://) + hostname=$(echo "${1}" | sed -E 's/^\s*.*:\/\///g') + # removes the first encounter of a forward slash / until the end of the string + hostname=${hostname%%/*} + # removes the first encounter of a colon : until the end of the string i.e [email protected]:apache -> [email protected] + hostname=${hostname%%:*} + # removes the username portion of an URI i.e. [email protected] -> github.com + hostname=$(echo "${hostname}" | cut -d@ -f2-) + + echo "${hostname}" +} + +test_get_hostname() { Review Comment: 👍 (except my terminal tab exit when running the test, which is expected :)) ########## scripts/functions.sh: ########## @@ -0,0 +1,42 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +get_hostname() { + if [[ $# -eq 0 ]] ; then + echo 'An URI must be provided' + exit 1 + fi + + # removes the scheme portion of the URI (i.e. https://, http://) + hostname=$(echo "${1}" | sed -E 's/^\s*.*:\/\///g') + # removes the first encounter of a forward slash / until the end of the string + hostname=${hostname%%/*} + # removes the first encounter of a colon : until the end of the string i.e [email protected]:apache -> [email protected] + hostname=${hostname%%:*} + # removes the username portion of an URI i.e. [email protected] -> github.com + hostname=$(echo "${hostname}" | cut -d@ -f2-) + + echo "${hostname}" +} + +test_get_hostname() { Review Comment: 👍 (except my terminal tab exit when running the test, which is expected :)) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
