Mmuzaf commented on PR #2506: URL: https://github.com/apache/cassandra/pull/2506#issuecomment-1652191025
The `ForwardingInfo` class: - all of the if-else statements `version >= VERSION_40` can be simplified, right? - according to the TODO statement ['in the next protocol version only serialize peers, message id will become redundant once 3.0 is out of the picture'](https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/net/ForwardingInfo.java#L42) we can get rid of `messageIds` field or am I missing something? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
