michaelsembwever commented on code in PR #2506:
URL: https://github.com/apache/cassandra/pull/2506#discussion_r1276226051
##########
test/unit/org/apache/cassandra/locator/InetAddressAndPortSerializerTest.java:
##########
@@ -37,8 +37,10 @@ public void testRoundtrip() throws Exception
InetAddressAndPort ipv4 = InetAddressAndPort.getByName("127.0.0.1:42");
InetAddressAndPort ipv6 =
InetAddressAndPort.getByName("[2001:db8:0:0:0:ff00:42:8329]:42");
- testAddress(ipv4, MessagingService.VERSION_30);
- testAddress(ipv6, MessagingService.VERSION_30);
+ testAddress(ipv4, MessagingService.VERSION_40);
+ testAddress(ipv6, MessagingService.VERSION_40);
+ testAddress(ipv4, MessagingService.minimum_version);
+ testAddress(ipv6, MessagingService.minimum_version);
Review Comment:
actually… i should loop through supportedVersions()
##########
test/unit/org/apache/cassandra/locator/InetAddressAndPortSerializerTest.java:
##########
@@ -37,8 +37,10 @@ public void testRoundtrip() throws Exception
InetAddressAndPort ipv4 = InetAddressAndPort.getByName("127.0.0.1:42");
InetAddressAndPort ipv6 =
InetAddressAndPort.getByName("[2001:db8:0:0:0:ff00:42:8329]:42");
- testAddress(ipv4, MessagingService.VERSION_30);
- testAddress(ipv6, MessagingService.VERSION_30);
+ testAddress(ipv4, MessagingService.VERSION_40);
+ testAddress(ipv6, MessagingService.VERSION_40);
+ testAddress(ipv4, MessagingService.minimum_version);
+ testAddress(ipv6, MessagingService.minimum_version);
Review Comment:
actually… i should loop through supportedVersions()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
