michaelsembwever commented on code in PR #2506:
URL: https://github.com/apache/cassandra/pull/2506#discussion_r1276234445
##########
test/unit/org/apache/cassandra/db/ReadResponseTest.java:
##########
@@ -162,12 +162,8 @@ public void makeDigestDoesntConsiderRepairedDataInfo()
}
private void verifySerDe(ReadResponse response) {
- // check that roundtripping through ReadResponse.serializer behaves as
expected.
- // ReadResponses from pre-4.0 nodes will never contain repaired data
digest
- // or pending session info, but we run all messages through both
pre/post 4.0
- // serde to check that the defaults are correctly applied
+ // check that roundtripping through ReadResponse.serializer behaves as
expected
roundTripSerialization(response, MessagingService.current_version);
Review Comment:
going to loop through supportedVersions()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
