yifan-c commented on code in PR #51:
URL: https://github.com/apache/cassandra-sidecar/pull/51#discussion_r1276927372
##########
src/test/integration/org/apache/cassandra/testing/CassandraIntegrationTest.java:
##########
@@ -94,4 +96,32 @@
*/
boolean nativeTransport() default true;
+ /**
+ * Return whether the cluster should be started before the test begins.
+ * It may be necessary to delay start/start in a thread if using
ByteBuddy-based
+ * interception of cluster startup.
+ * @return true, if the cluster should be started before the test starts,
false otherwise
+ */
+ boolean startCluster() default true;
+
+ /**
+ * Return whether the cluster should be built, or to simply add the
cluster builder to the context.
+ * This may be useful in cases where the test requires more complex
cluster startup.
+ * If false, the test should take an instance of {@link
ConfigurableCassandraTestContext}
+ * and call {@link
ConfigurableCassandraTestContext#configureCluster(Consumer)}
+ * or {@link
ConfigurableCassandraTestContext#configureAndStartCluster(Consumer)} to get the
cluster.
+ * NOTE: This cluster object must be closed by the test as the
framework doesn't have access to it.
+ * If true (the default), the test should take an instance of {@link
CassandraTestContext}
+ * {@link CassandraTestContext#getCluster()} will contain the
built cluster.
+ * @return true if the cluster should be built by the test framework,
false otherwise
+ */
+ boolean buildCluster() default true;
+
+ /**
+ * If the integration test does not need to be run on each version of
Cassandra, set this to false
+ * and it will be run only on the first version specified.
+ * @return true if the test should be run on all tested versions of
Cassandra,
+ * false if it should be run on the first version.
+ */
+ boolean versionDependent() default true;
Review Comment:
it makes a lot of sense!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
