yifan-c commented on code in PR #51:
URL: https://github.com/apache/cassandra-sidecar/pull/51#discussion_r1280880325


##########
common/src/main/java/org/apache/cassandra/sidecar/cluster/InstancesConfigImpl.java:
##########
@@ -85,10 +85,12 @@ public InstanceMetadata instanceFromHost(String host) 
throws NoSuchElementExcept
             }
             catch (UnknownHostException e)
             {
-                throw new NoSuchElementException("Instance with host address "
-                                                 + host +
-                                                 " not found, and an error 
occurred when " +
-                                                 "attempting to get its IP 
address.");
+                NoSuchElementException error = new 
NoSuchElementException("Instance with host address "
+                                                      + host +
+                                                      " not found, and an 
error occurred when " +
+                                                      "attempting to resolve 
its IP address.");
+                error.initCause(e);

Review Comment:
   👍 



##########
common/src/main/java/org/apache/cassandra/sidecar/cluster/InstancesConfigImpl.java:
##########
@@ -85,10 +85,12 @@ public InstanceMetadata instanceFromHost(String host) 
throws NoSuchElementExcept
             }
             catch (UnknownHostException e)
             {
-                throw new NoSuchElementException("Instance with host address "
-                                                 + host +
-                                                 " not found, and an error 
occurred when " +
-                                                 "attempting to get its IP 
address.");
+                NoSuchElementException error = new 
NoSuchElementException("Instance with host address "
+                                                      + host +
+                                                      " not found, and an 
error occurred when " +
+                                                      "attempting to resolve 
its IP address.");
+                error.initCause(e);

Review Comment:
   👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to