aweisberg commented on code in PR #54:
URL: https://github.com/apache/cassandra-accord/pull/54#discussion_r1282427075
##########
accord-core/src/main/java/accord/local/CommonAttributes.java:
##########
@@ -84,6 +80,7 @@ public TxnId txnId()
public Mutable txnId(TxnId txnId)
{
+ Invariants.checkState(this != EMPTY_ATTRS && this !=
EMPTY_ATTRS_NONE_PARTIAL_DEPS, "Don't mutate the global empty instances");
Review Comment:
I'll remove the EMPTY instances so it won't matter
##########
accord-core/src/main/java/accord/local/Command.java:
##########
@@ -685,25 +819,29 @@ public Ballot accepted()
public static class Committed extends Accepted
{
- private final ImmutableSortedSet<TxnId> waitingOnCommit;
- private final ImmutableSortedMap<Timestamp, TxnId> waitingOnApply;
+ public static final Committed EMPTY = new
Committed(SaveStatus.Committed);
Review Comment:
I'll remove them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
