aweisberg commented on code in PR #54:
URL: https://github.com/apache/cassandra-accord/pull/54#discussion_r1282432669
##########
accord-core/src/main/java/accord/local/Command.java:
##########
@@ -685,25 +819,29 @@ public Ballot accepted()
public static class Committed extends Accepted
{
- private final ImmutableSortedSet<TxnId> waitingOnCommit;
- private final ImmutableSortedMap<Timestamp, TxnId> waitingOnApply;
+ public static final Committed EMPTY = new
Committed(SaveStatus.Committed);
Review Comment:
Why is it a breaking change? The empty object returned is always measurable
at runtime so if it changes so will the empty size. Empty size is for in memory
footprint, serialization explicitly goes through the fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
