maedhroz commented on code in PR #2540:
URL: https://github.com/apache/cassandra/pull/2540#discussion_r1283995173
##########
test/unit/org/apache/cassandra/index/sai/utils/AbstractPrimaryKeyTester.java:
##########
@@ -154,7 +154,7 @@ DecoratedKey makeKey(TableMetadata table,
Object...partitionKeys)
return table.partitioner.decorateKey(key);
Review Comment:
nit: It might be nicer to use `key =
table.partitionKeyType.decomposeUntyped(partitionKeys[0]);` above on 153 to
avoid some unnecessary `String` conversions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
