adelapena commented on code in PR #2540:
URL: https://github.com/apache/cassandra/pull/2540#discussion_r1287025552
##########
src/java/org/apache/cassandra/index/sai/disk/v1/bitpack/NumericValuesWriter.java:
##########
@@ -22,79 +22,98 @@
import javax.annotation.concurrent.NotThreadSafe;
+import com.google.common.annotations.VisibleForTesting;
+
import org.apache.cassandra.index.sai.disk.format.IndexComponent;
import org.apache.cassandra.index.sai.disk.format.IndexDescriptor;
import org.apache.cassandra.index.sai.disk.v1.MetadataWriter;
import org.apache.cassandra.index.sai.disk.v1.SAICodecUtils;
import org.apache.lucene.store.IndexOutput;
@NotThreadSafe
-public class NumericValuesWriter implements Closeable
+public interface NumericValuesWriter extends Closeable
{
- public static final int MONOTONIC_BLOCK_SIZE = 16384;
- public static final int BLOCK_SIZE = 128;
-
- private final IndexOutput output;
- private final AbstractBlockPackedWriter writer;
- private final MetadataWriter metadataWriter;
- private final String componentName;
- private final int blockSize;
- private long count = 0;
-
- public NumericValuesWriter(String componentName,
- IndexOutput indexOutput,
- MetadataWriter metadataWriter,
- boolean monotonic) throws IOException
+ NumericValuesWriter NOOP_WRITER = new NumericValuesWriter()
Review Comment:
This doesn't seem used anywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
