mike-tr-adamson commented on code in PR #2540:
URL: https://github.com/apache/cassandra/pull/2540#discussion_r1288490587
##########
test/unit/org/apache/cassandra/index/sai/disk/v1/bitpack/NumericValuesTest.java:
##########
@@ -106,11 +106,11 @@ private void writeTokens(boolean monotonic,
IndexDescriptor indexDescriptor, lon
long current = 0;
try (MetadataWriter metadataWriter = new
MetadataWriter(indexDescriptor.openPerSSTableOutput(IndexComponent.GROUP_META));
- final NumericValuesWriter numericWriter = new
NumericValuesWriter(indexDescriptor,
-
IndexComponent.TOKEN_VALUES,
-
metadataWriter,
-
monotonic,
-
blockSize))
+ final NumericValuesWriter numericWriter =
NumericValuesWriter.create(indexDescriptor,
+
IndexComponent.TOKEN_VALUES,
+
metadataWriter,
+
monotonic,
+
blockSize))
Review Comment:
No, I think this was just laziness by whoever wrote the test. I've changed
it to generate longs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
