dcapwell commented on code in PR #57:
URL: https://github.com/apache/cassandra-accord/pull/57#discussion_r1294873354
##########
accord-core/src/main/java/accord/impl/AbstractConfigurationService.java:
##########
@@ -269,6 +269,13 @@ public synchronized void reportTopology(Topology topology,
boolean startSync)
}
long lastAcked = epochs.lastAcknowledged;
+ // TODO (now, review): lastAcked == 0, lastReceived = 2
+ // if we wait for epoch=1.acknowledge the test seems to wait
forever... looks like burn test doesn't ack epoch=1
+ if (lastAcked == 0 && lastReceived > 0)
Review Comment:
have to think about this.. when starting up with the topology we can reach
received right away, but we don't see an ack until
```
public void acknowledgeEpoch(EpochReady ready)
{
ready.metadata.addCallback(() -> {
synchronized (AbstractConfigurationService.this)
{
epochs.acknowledge(ready);
}
});
```
so `accord.local.CommandStore#bootstrapper` is the main thing blocking the
metadata... so it would be possible that a new node joins the ring, has to
bootstrap its state, then receive topology updates.... so waiting on `minEpoch`
still makes sense to me...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
