dcapwell commented on code in PR #57:
URL: https://github.com/apache/cassandra-accord/pull/57#discussion_r1294887984
##########
accord-core/src/test/java/accord/impl/basic/Cluster.java:
##########
@@ -190,6 +172,12 @@ private void processNext(Object next)
}
}
+ public void notifyDropped(Node.Id from, Node.Id to, long id, Message
message)
Review Comment:
only here to keep the trace logging from before... im cool dropping. We now
have more detailed debug logs for messaging
##########
accord-core/src/test/java/accord/impl/basic/NodeSink.java:
##########
@@ -33,11 +44,20 @@
import accord.messages.Reply;
import accord.messages.ReplyContext;
import accord.messages.Request;
+import com.google.common.collect.ImmutableSet;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import static accord.impl.basic.Packet.SENTINEL_MESSAGE_ID;
+import static java.util.concurrent.TimeUnit.SECONDS;
public class NodeSink implements MessageSink
{
+ private static final boolean DEBUG = false;
+ private enum Action {DELIVER, DROP, DROP_PARTITIONED, FAILURE}
Review Comment:
in follow up patches I add client actions as well, so we get a more complete
view
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
