aweisberg commented on code in PR #56:
URL: https://github.com/apache/cassandra-accord/pull/56#discussion_r1298577697
##########
accord-core/src/main/java/accord/messages/ReadData.java:
##########
@@ -153,7 +153,11 @@ void read(SafeCommandStore safeStore, Timestamp executeAt,
PartialTxn txn)
{
// TODO (expected, exceptions): should send exception to
client, and consistency handle/propagate locally
logger.trace("{}: read failed for {}: {}", txnId, unsafeStore,
throwable);
- node.reply(replyTo, replyContext, ReadNack.Error);
+ synchronized (ReadData.this)
Review Comment:
You are right it probably isn't necessary. I reflexively added it because
the existing call to `cancel` is from a `synchronized` method, but the actual
implementations of cancel don't require it to be `synchronized` and are
probably also idempotent so it's fine if multiple responses and cancellations
happen at once. I'll remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
