aweisberg commented on code in PR #56:
URL: https://github.com/apache/cassandra-accord/pull/56#discussion_r1298611746
##########
accord-core/src/main/java/accord/messages/ReadTxnData.java:
##########
@@ -231,8 +231,14 @@ protected synchronized void readComplete(CommandStore
commandStore, @Nullable Da
}
@Override
- protected void reply(@Nullable Ranges unavailable, @Nullable Data data)
+ protected void reply(@Nullable Ranges unavailable, @Nullable Data data,
@Nullable Throwable fail)
{
+ if (fail != null)
+ {
+ node.reply(replyTo, replyContext, null, fail);
Review Comment:
Shouldn't this also have the same illegal state logic as well? Maybe the
fail handling should be in the switch below and handle obsolete as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
