blerer commented on PR #2655: URL: https://github.com/apache/cassandra/pull/2655#issuecomment-1704928926
Thanks for all the feedback. After thinking about that code over the weekend, I realized that I misunderstood some part of the existing code and worst than that it seems that I am not the only one. @Maxwell-Guo question about Vectors, triggered some investigation on my side. The code work but the path being used is not the one that people would expect. It was also the case for Tuples before that patch. My feeling is that the code is more confusing than I realized and needs to be refactored further. I am going back to the drawing board. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
