yifan-c commented on code in PR #67:
URL: https://github.com/apache/cassandra-sidecar/pull/67#discussion_r1316488896
##########
src/main/dist/conf/sidecar.yaml:
##########
@@ -75,6 +75,7 @@ sidecar:
sstable_upload:
concurrent_upload_limit: 80
min_free_space_percent: 10
+ # file_permissions: # when not specified, the default permissions are
"rw-r--r--"
Review Comment:
Rephrase the comment so the part before `#` is a valid form, it provides the
guidance on the acceptable format of the value.
```suggestion
# file_permissions: "rw-r--r--" # when not specified, the default file
permissions is owner read & write, others & group read
```
##########
src/main/java/org/apache/cassandra/sidecar/config/impl/SSTableUploadConfigurationImpl.java:
##########
@@ -78,4 +110,20 @@ public float minimumSpacePercentageRequired()
{
return minimumSpacePercentageRequired;
}
+
+ /**
+ * Returns the String representation of a set of posix file permissions
used during an SSTable file upload.
+ * When an SSTable file is created the specified permissions will be used
to create the file.
+ * For example, the String {@code rw-r--r--} represents the set of
permissions
+ * {@link PosixFilePermission#OWNER_READ}, {@link
PosixFilePermission#OWNER_WRITE},
+ * {@link PosixFilePermission#GROUP_READ}, and {@link
PosixFilePermission#OTHERS_READ}.
+ *
+ * @return the String representation of a set of posix file permissions
used during an SSTable file upload
+ */
Review Comment:
nit: can we simply have the following
```
/**
* {@inheritDoc}
*/
```
I know that the other methods in the class have the copy-pasted java docs
already.. would appreciate less code, including repeated docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
