frankgh commented on code in PR #67:
URL: https://github.com/apache/cassandra-sidecar/pull/67#discussion_r1316496096
##########
src/main/java/org/apache/cassandra/sidecar/config/impl/SSTableUploadConfigurationImpl.java:
##########
@@ -78,4 +110,20 @@ public float minimumSpacePercentageRequired()
{
return minimumSpacePercentageRequired;
}
+
+ /**
+ * Returns the String representation of a set of posix file permissions
used during an SSTable file upload.
+ * When an SSTable file is created the specified permissions will be used
to create the file.
+ * For example, the String {@code rw-r--r--} represents the set of
permissions
+ * {@link PosixFilePermission#OWNER_READ}, {@link
PosixFilePermission#OWNER_WRITE},
+ * {@link PosixFilePermission#GROUP_READ}, and {@link
PosixFilePermission#OTHERS_READ}.
+ *
+ * @return the String representation of a set of posix file permissions
used during an SSTable file upload
+ */
Review Comment:
good point, IntelliJ did the copy/paste work for me already :), but it's
more work for the reviewer. I will follow your recommendation. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
