Maxwell-Guo commented on code in PR #2746:
URL: https://github.com/apache/cassandra/pull/2746#discussion_r1339854163
##########
src/java/org/apache/cassandra/db/marshal/VectorType.java:
##########
@@ -215,7 +217,8 @@ public <V> ByteSource asComparableBytes(ValueAccessor<V>
accessor, V value, Byte
public <V> V fromComparableBytes(ValueAccessor<V> accessor,
ByteSource.Peekable comparableBytes, ByteComparable.Version version)
{
if (comparableBytes == null)
- return accessor.empty();
+ rejectEmptyValue();
Review Comment:
ok, that is all right.~~~~ But I still have to explain the reason why I ask
this question , because I have checked the cassandra's code , but don't find
any function which only throw exception and the function name(rejectEmptyValue)
are also a bit less straightforward in explaining behavior to me .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
