Maxwell-Guo commented on code in PR #2746:
URL: https://github.com/apache/cassandra/pull/2746#discussion_r1340134603
##########
src/java/org/apache/cassandra/db/marshal/VectorType.java:
##########
@@ -215,7 +217,8 @@ public <V> ByteSource asComparableBytes(ValueAccessor<V>
accessor, V value, Byte
public <V> V fromComparableBytes(ValueAccessor<V> accessor,
ByteSource.Peekable comparableBytes, ByteComparable.Version version)
{
if (comparableBytes == null)
- return accessor.empty();
+ rejectEmptyValue();
Review Comment:
Besides, what about rename the funtion to something like
rejectNullOrEmptyValue ? as you have said "The purpose here is to make sure
that all similar null/empty errors throw the same exception and message."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
