jacek-lewandowski commented on code in PR #2648:
URL: https://github.com/apache/cassandra/pull/2648#discussion_r1344247729
##########
src/java/org/apache/cassandra/metrics/ChunkCacheMetrics.java:
##########
@@ -72,14 +73,14 @@ public void recordLoadFailure(long loadTime)
}
@Override
- public void recordEviction()
+ public void recordEviction(int weight, RemovalCause cause)
{
}
@Nonnull
@Override
public CacheStats snapshot()
{
- return new CacheStats(hits.getCount(), misses.getCount(),
missLatency.getCount(), 0L, missLatency.getCount(), 0L, 0L);
+ return CacheStats.of(hits.getCount(), misses.getCount(),
missLatency.getCount(), 0L, missLatency.getCount(), 0L, 0L);
Review Comment:
you are right, though `missLatency.getCount()` is also used for load time,
and in this case it is probably wrong; anyway, it is out of the scope
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
