skoppu22 commented on code in PR #2648:
URL: https://github.com/apache/cassandra/pull/2648#discussion_r1341324134
##########
src/java/org/apache/cassandra/metrics/ChunkCacheMetrics.java:
##########
@@ -72,14 +73,14 @@ public void recordLoadFailure(long loadTime)
}
@Override
- public void recordEviction()
+ public void recordEviction(int weight, RemovalCause cause)
{
}
@Nonnull
@Override
public CacheStats snapshot()
{
- return new CacheStats(hits.getCount(), misses.getCount(),
missLatency.getCount(), 0L, missLatency.getCount(), 0L, 0L);
+ return CacheStats.of(hits.getCount(), misses.getCount(),
missLatency.getCount(), 0L, missLatency.getCount(), 0L, 0L);
Review Comment:
My understanding is: missLatency is recorded whenever there is a cache miss
and an entry is loaded into the cache. missLatency.getCount() returns number of
times successful cache load happened. Which seems correct based on this
understanding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
