Claudenw commented on code in PR #2783:
URL: https://github.com/apache/cassandra/pull/2783#discussion_r1350184218


##########
src/java/org/apache/cassandra/gms/Gossiper.java:
##########
@@ -600,11 +600,12 @@ public void convict(InetAddressAndPort endpoint, double 
phi)
      * This method is used to mark a node as shutdown; that is it gracefully 
exited on its own and told us about it
      * @param endpoint endpoint that has shut itself down
      */
+    @Deprecated // can remove once 4.x is not supported

Review Comment:
   Should this use the "since" property of the Deprecated annotation? 
   
   i.e. @Deprecated(since="5.0")



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to