driftx commented on code in PR #2783:
URL: https://github.com/apache/cassandra/pull/2783#discussion_r1350540778
##########
src/java/org/apache/cassandra/gms/Gossiper.java:
##########
@@ -600,11 +600,12 @@ public void convict(InetAddressAndPort endpoint, double
phi)
* This method is used to mark a node as shutdown; that is it gracefully
exited on its own and told us about it
* @param endpoint endpoint that has shut itself down
*/
+ @Deprecated // can remove once 4.x is not supported
protected void markAsShutdown(InetAddressAndPort endpoint)
{
checkProperThreadForStateMutation();
EndpointState epState = endpointStateMap.get(endpoint);
- if (epState == null)
+ if (epState == null || epState.isStateEmpty())
Review Comment:
Is this enough to prevent the issue without sending the endpoint state? If
so maybe we can do this in lower branches?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
