dcapwell commented on code in PR #2784:
URL: https://github.com/apache/cassandra/pull/2784#discussion_r1351047791
##########
conf/cassandra.yaml:
##########
@@ -2113,3 +2110,15 @@ accord_transactions_enabled: false
# a stable cluster. If a node from a previous version was started by
accident we won't any longer toggle behaviors as when UPGRADING.
#
storage_compatibility_mode: NONE
+
+accord:
Review Comment:
need to comment this out; non of the fields are defined outside comments
##########
src/java/org/apache/cassandra/config/Config.java:
##########
@@ -1129,6 +1123,8 @@ public enum PaxosOnLinearizabilityViolation
*/
public ParameterizedClass default_compaction = null;
+ public volatile AccordSpec accord = new AccordSpec();
Review Comment:
don't need `volatile` here, `final` is better... we only mutate the leaf
fields, not the complex fields
##########
conf/cassandra.yaml:
##########
@@ -2113,3 +2110,15 @@ accord_transactions_enabled: false
# a stable cluster. If a node from a previous version was started by
accident we won't any longer toggle behaviors as when UPGRADING.
#
storage_compatibility_mode: NONE
+
+accord:
+ # Enables the execution of Accord (multi-key) transactions on this node.
+ # accord_transactions_enabled: false
Review Comment:
think this is just `enabled`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
